Skip to content

Homework 03 Chore: Added Jerimiah's Quiz #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 12, 2025
Merged

Homework 03 Chore: Added Jerimiah's Quiz #135

merged 12 commits into from
Mar 12, 2025

Conversation

Dlafferty251
Copy link
Contributor

Hello this is my pr regarding davids addition to lesson 03

anthonydmays
anthonydmays requested changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@anthonydmays anthonydmays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should not include any lesson_01 work. Also, you should only have your changes in this PR, not David's. It looks like you can just delete anything that isn't your changes and that would get this PR in better shape.

@Dlafferty251
Copy link
Contributor Author

I deleted both Khayla and Meikos HTML files I guess they showed up because when I pulled to get davids quiz it also pulled that I'm sorry I really think Im good I did npm run check and made sure no extra files were added i mean it says I deleted meikos file but that should be ok right??

Dlafferty251
Dlafferty251 commented Mar 12, 2025
View reviewed changes
Copy link
Contributor Author

@Dlafferty251 Dlafferty251 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing Up Some files to make merge check work

@Dlafferty251 Dlafferty251 changed the title Homework 03 Added Davids Quiz Homework 03 Chore: Added Davids Quiz Mar 12, 2025
@Dlafferty251
Copy link
Contributor Author

I have added Khaylas Quiz to the repo

Dlafferty251
Dlafferty251 commented Mar 12, 2025
View reviewed changes
Copy link
Contributor Author

@Dlafferty251 Dlafferty251 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I Have Reviewed changes the files being changed are me deleting lesson_01 work

@Dlafferty251 Dlafferty251 changed the title Homework 03 Chore: Added Davids Quiz Homework 03 Chore: Added Khaylas Quiz Mar 12, 2025
@Dlafferty251
Copy link
Contributor Author

I have added jasons quiz

@Dlafferty251 Dlafferty251 changed the title Homework 03 Chore: Added Khaylas Quiz Homework 03 Chore: Added Jasons Quiz Mar 12, 2025
@Dlafferty251 Dlafferty251 changed the title Homework 03 Chore: Added Jasons Quiz Homework 03 Chore: Added Jerimiah's Quiz Mar 12, 2025
anthonydmays
anthonydmays approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@anthonydmays anthonydmays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anthonydmays anthonydmays merged commit 4bb35ec into code-differently:main Mar 12, 2025
1 check passed
@Dlafferty251 Dlafferty251 deleted the Homework_03_pt2 branch March 13, 2025 00:31
@Dlafferty251 Dlafferty251 mentioned this pull request Mar 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonydmays anthonydmays anthonydmays approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dlafferty251 @anthonydmays @Dadenaike251